Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 개발 서버 마이그레이션 #933

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

mzeong
Copy link
Contributor

@mzeong mzeong commented Dec 23, 2024

🚩 연관 이슈

close #927


📝 작업 내용

개발 서버 마이그레이션 과정 중에 레디스 호스트 변경으로 yml 파일 수정이 있었습니다


🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

@mzeong mzeong self-assigned this Dec 23, 2024
Copy link

Test Results

 61 files   61 suites   12s ⏱️
207 tests 207 ✅ 0 💤 0 ❌
208 runs  208 ✅ 0 💤 0 ❌

Results for commit 29d6e29.

Copy link

📝 Test Coverage Report

Overall Project 82.64% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

@coli-geonwoo coli-geonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제리, 몇가지 질문이 있어 우선 RC로 남겨두어요.
특히 redis의 host명을 바꾸어준 부분에 대해 ody-dev-redis와 ody-prod-redis를 각각 어떻게 설정했는지 알고 싶습니다!

@@ -22,7 +22,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
ref: develop
ref: feature/927
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger를 다시 복구해주어야 할 것 같아요!

@@ -1,7 +1,7 @@
spring:
data:
redis:
host: ody-redis-001.ody-redis.vd1e5e.apn2.cache.amazonaws.com
host: ody-dev-redis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[질문]

  • 여기서 ody-dev-redis와 ody-prod-redis는 어떻게 설정해주었나요? 원래는 카키 계정의 elastic cache를 통해 소통하는 것으로 알았는데, 제리가 어디에 어떻게 redis를 설정해놓았는지 이야기해주면 고마울 것 같아요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: 개발 서버 마이그레이션
2 participants